Check monad laws for Cokleisli #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1590 +/- ##
=========================================
+ Coverage 92.42% 92.52% +0.1%
=========================================
Files 249 249
Lines 3974 3974
Branches 138 138
=========================================
+ Hits 3673 3677 +4
+ Misses 301 297 -4
Continue to review full report at Codecov.
|
kailuowang
approved these changes
Apr 6, 2017
| @@ -8,7 +8,6 @@ import cats.laws.discipline._ | |||
| import cats.laws.discipline.arbitrary._ | |||
| import cats.laws.discipline.eq._ | |||
| import org.scalacheck.Arbitrary | |||
| import cats.laws.discipline.{SemigroupKTests, MonoidKTests} | |||
There was a problem hiding this comment.
Hmmm if they are unused how come they passed the build before? Just curious
|
👍 thanks @peterneyens! |
|
merge with two sign-off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.