Use Cogen for Kleisli and Func Arbitrary instances #1606
Closed
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that this resolves typelevel#1605. It may have merge conflicts with typelevel#1584 and I think that one should probably be merged first. I noticed a slight discrepancy between how I've implemented this (taking implicit `Cogen` and `Arbitrary` instances) vs how the current `StateT` arbitrary instance works (it takes an implicit `Arbitrary[S => F[(S, A)]]]). I'm not really sure whether one approach is better than the other. We should probably align on one of the two, though.
edmundnoble
suggested changes
Apr 18, 2017
There was a problem hiding this comment.
I believe you are correct in your assessment of the necessity to standardise, and I think the best solution is to standardise on taking in the Arbitrary specialised to the function instance (as done with StateT). It's more flexible; just in case you do want any constant functions you can provide them via an Arbitrary function instance, because we avoid baking in the in-built Arbitrary function instances.
|
Thanks for the feedback @edmundnoble. I'm going to go ahead and close out this PR and open a new one that uses the approach that you suggested and that doesn't have merge conflicts. |
ceedubs
added a commit
to ceedubs/cats
that referenced
this pull request
Apr 21, 2017
Resolves typelevel#1605. This is a replacement for typelevel#1606.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that this resolves #1605. It may have merge conflicts with #1584
and I think that one should probably be merged first.
I noticed a slight discrepancy between how I've implemented this (taking
implicit
CogenandArbitraryinstances) vs how the currentStateTarbitrary instance works (it takes an implicit
Arbitrary[S => F[(S, A)]]]). I'm not really sure whether one approach is better than the other. We should probably align on one of the two, though.