Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage IdT #1623

Merged
merged 2 commits into from
Jul 1, 2017
Merged

Conversation

peterneyens
Copy link
Collaborator

I am not sure how often IdT is actually used, but this PR should improve its test coverage.

I think it makes sense to merge #1621 first, I will replace TransLift with MonadTrans in this PR afterwards.

@codecov-io
Copy link

codecov-io commented Apr 22, 2017

Codecov Report

Merging #1623 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1623      +/-   ##
==========================================
+ Coverage   93.88%   94.06%   +0.17%     
==========================================
  Files         246      246              
  Lines        4088     4094       +6     
  Branches      154      160       +6     
==========================================
+ Hits         3838     3851      +13     
+ Misses        250      243       -7
Impacted Files Coverage Δ
core/src/main/scala/cats/data/IdT.scala 96.66% <100%> (+25.83%) ⬆️
...rc/main/scala/cats/laws/discipline/Arbitrary.scala 92.06% <0%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1931c93...c7f0e00. Read the comment docs.

@peterneyens
Copy link
Collaborator Author

Updated to use MonadTrans and added some missing serializable tests for MonadTrans instances.

@peterneyens peterneyens changed the title Improve test coverage IdT (wip) Improve test coverage IdT May 20, 2017
@kailuowang
Copy link
Contributor

👍

@kailuowang kailuowang merged commit c012417 into typelevel:master Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants