Use 2 workers in JVM build #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell, our CI build has 2 cores available on Travis. So I suspect that 2 workers might be a sweet spot for our JVM testing. As I understand it, the JS runtime is single-threaded, so we probably won't benefit from additional workers on it (as our tests should be CPU-bound). I could be totally wrong about these assumptions, but I'm interested in how the build times for this PR compare.
|
In the first build, this seems to reduce the JVM build from ~35min to ~30 min. It's tough to infer based on a sample size of 1 though. |
Codecov Report
@@ Coverage Diff @@
## master #1673 +/- ##
=======================================
Coverage 93.43% 93.43%
=======================================
Files 241 241
Lines 4068 4068
Branches 140 140
=======================================
Hits 3801 3801
Misses 267 267Continue to review full report at Codecov.
|
|
I'm going to restart the build to try to see whether the times are consistent. |
|
There seem to be similar results (or even a bit better) on the second build. |
kailuowang
approved these changes
May 17, 2017
peterneyens
approved these changes
May 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, our CI build has 2 cores available on Travis. So I
suspect that 2 workers might be a sweet spot for our JVM testing. As I
understand it, the JS runtime is single-threaded, so we probably won't
benefit from additional workers on it (as our tests should be
CPU-bound).
I could be totally wrong about these assumptions, but I'm interested in
how the build times for this PR compare.