remove Unapply fixes #1607 #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterneyens
approved these changes
May 18, 2017
kailuowang
force-pushed
the
remove-unapply
branch
from
6aed946
to
96c4c70
Compare
ceedubs
approved these changes
May 18, 2017
Codecov Report
@@ Coverage Diff @@
## master #1679 +/- ##
==========================================
+ Coverage 93.42% 93.83% +0.41%
==========================================
Files 242 241 -1
Lines 4075 4055 -20
Branches 140 139 -1
==========================================
- Hits 3807 3805 -2
+ Misses 268 250 -18Continue to review full report at Codecov.
|
This was referenced May 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that everyone agrees that
Unapplyshouldn't exist in cats.core any more. I propose we remove it first and we can find a place for it later if we need to. Leaving in cats may cause some confusion. e.g. people may still use it to addxxxxUversions, etc.