Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build JVM before JS on travis #1691

Merged
merged 1 commit into from
May 21, 2017

Conversation

peterneyens
Copy link
Collaborator

@peterneyens peterneyens commented May 20, 2017

If there are no other builds (for other PRs, branches, ...), switching the JVM/JS order to JS/JVM can be 10-15 minutes quicker.

There are now 6 Travis jobs for every build (3 Scala versions and JVM / JS) and only 5 are executing at the same time. By switching the order, the three longer JVM jobs are started first and when the 2.11 JS job finishes, the 2.12 JS job can start (which doesn't take as long as the 2.12 JVM job which is now started last).

I ran Travis twice resulting in total build times of 31 and 39 minutes while the last master builds took around 50 minutes.

This is just a minor improvement of the Travis matrix build change by @kailuowang in #1671.

@codecov-io
Copy link

codecov-io commented May 20, 2017

Codecov Report

Merging #1691 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1691   +/-   ##
=======================================
  Coverage   93.94%   93.94%           
=======================================
  Files         241      241           
  Lines        4096     4096           
  Branches      156      156           
=======================================
  Hits         3848     3848           
  Misses        248      248

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc4080c...ed325b2. Read the comment docs.

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks! I plan to research how to have more than 5 concurrent executions, but I guess you already did and it's not possible.

@djspiewak
Copy link
Member

This is great. Thanks! I plan to research how to have more than 5 concurrent executions, but I guess you already did and it's not possible.

It's part of their commercial offering.

@kailuowang kailuowang merged commit ee8abce into typelevel:master May 21, 2017
@peterneyens peterneyens deleted the travis-jvm-first branch May 21, 2017 12:08
@kailuowang kailuowang modified the milestone: 1.0.0-MF May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants