Make syntax.show extend ShowSyntax instead of Show.ToShowOps #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edmundnoble it looks like this broke |
|
@ceedubs Fixed by removing the explicit import, it's odd that it would work this way but I think it's because it's shadowed by importing it when it's already in scope (through |
Codecov Report
@@ Coverage Diff @@
## master #1696 +/- ##
=======================================
Coverage 94.02% 94.02%
=======================================
Files 256 256
Lines 4201 4201
Branches 84 84
=======================================
Hits 3950 3950
Misses 251 251Continue to review full report at Codecov.
|
peterneyens
approved these changes
Jul 6, 2017
kailuowang
approved these changes
Jul 6, 2017
hseeberger
pushed a commit
to hseeberger/akka-http-json
that referenced
this pull request
Nov 2, 2017
* Upgrade to circe 0.9.0-M2 * Import new implicit for cats show See cats PR 1696 typelevel/cats#1696
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nobody can use the
showinterpolator otherwise with a-la-carte imports 😝Edit: Thanks @alexknvl for pointing this out.