Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kleisli tap, tapWith #1769

Merged
merged 1 commit into from
Jul 21, 2017
Merged

Kleisli tap, tapWith #1769

merged 1 commit into from
Jul 21, 2017

Conversation

tpolecat
Copy link
Member

This adds a couple combinators that I was looking for today. tap exists in Scalaz, tapWith doesn't. I'm happy to take suggestions for better names.

@codecov-io
Copy link

codecov-io commented Jul 20, 2017

Codecov Report

Merging #1769 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1769      +/-   ##
==========================================
+ Coverage   95.26%   95.26%   +<.01%     
==========================================
  Files         265      265              
  Lines        4283     4285       +2     
  Branches       97       95       -2     
==========================================
+ Hits         4080     4082       +2     
  Misses        203      203
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Kleisli.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ea2ed...11988af. Read the comment docs.

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@tpolecat tpolecat merged commit 0df2821 into typelevel:master Jul 21, 2017
@tpolecat tpolecat deleted the kleisli-tap branch July 21, 2017 05:16
@kailuowang kailuowang modified the milestone: 1.0.0-MF Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants