Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add right and left functor to BiFunctor #1847

Merged
merged 3 commits into from
Aug 31, 2017

Conversation

LukaJCB
Copy link
Member

@LukaJCB LukaJCB commented Aug 23, 2017

Quick and dirty, should resolve #1834.

@codecov-io
Copy link

codecov-io commented Aug 23, 2017

Codecov Report

Merging #1847 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1847      +/-   ##
==========================================
+ Coverage   94.96%   94.97%   +<.01%     
==========================================
  Files         241      241              
  Lines        4173     4199      +26     
  Branches      106      111       +5     
==========================================
+ Hits         3963     3988      +25     
- Misses        210      211       +1
Impacted Files Coverage Δ
core/src/main/scala/cats/functor/Bifunctor.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/Monad.scala 96% <0%> (-0.16%) ⬇️
...ws/src/main/scala/cats/kernel/laws/OrderLaws.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/syntax/monad.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/syntax/cartesian.scala 50% <0%> (ø) ⬆️
free/src/main/scala/cats/free/Free.scala 91.04% <0%> (+1.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8458b24...eef68f2. Read the comment docs.

@kailuowang kailuowang added this to the 1.0.0-RC1 milestone Aug 28, 2017
@non
Copy link
Contributor

non commented Aug 30, 2017

Could we use a private abstract class (or even private case class) instead of trait?

Classes have a better binary compatibility story on 2.10 and 2.11 and I don't think we'll ever want to use these traits as mix-ins.

@LukaJCB
Copy link
Member Author

LukaJCB commented Aug 30, 2017

Done :)

@non
Copy link
Contributor

non commented Aug 31, 2017

Thanks! LGTM 👍

@non non merged commit d85cc86 into typelevel:master Aug 31, 2017
@LukaJCB LukaJCB deleted the add-left-right-functor branch August 31, 2017 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access to implied Functors from Bifunctor (and Bifoldable, Bitraverse)
4 participants