Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to fix contributing page #1895

Merged
merged 2 commits into from
Sep 8, 2017
Merged

trying to fix contributing page #1895

merged 2 commits into from
Sep 8, 2017

Conversation

kailuowang
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 7, 2017

Codecov Report

Merging #1895 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1895   +/-   ##
======================================
  Coverage    95.2%   95.2%           
======================================
  Files         248     248           
  Lines        4379    4379           
  Branches      125     125           
======================================
  Hits         4169    4169           
  Misses        210     210

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f2ecc...13746cb. Read the comment docs.

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with how this works, but it looks reasonable to me.

@ceedubs ceedubs merged commit 62dcde7 into master Sep 8, 2017
@kailuowang kailuowang deleted the fix-contribute branch September 8, 2017 19:00
@kailuowang
Copy link
Contributor Author

I will try republish the website shortly (we should be fine, no breaking change so far)

@kailuowang kailuowang added this to the 1.0.0-RC1 milestone Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants