Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Alternative law checking for IndexedStateT #1906

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Fix Alternative law checking for IndexedStateT #1906

merged 1 commit into from
Sep 12, 2017

Conversation

iravid
Copy link
Contributor

@iravid iravid commented Sep 12, 2017

MonoidK laws were being checked instead of Alternative.

@codecov-io
Copy link

codecov-io commented Sep 12, 2017 •
edited
Loading

Codecov Report

Merging #1906 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1906   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files         248      248           
  Lines        4396     4396           
  Branches      108      116    +8     
=======================================
  Hits         4192     4192           
  Misses        204      204

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb0252...ea67877. Read the comment docs.

ceedubs
ceedubs approved these changes Sep 12, 2017
View reviewed changes
Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @iravid!

@kailuowang kailuowang merged commit d97fd89 into typelevel:master Sep 12, 2017
@kailuowang kailuowang added this to the 1.0.0-RC1 milestone Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceedubs ceedubs ceedubs approved these changes

@kailuowang kailuowang kailuowang approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
1.0.0-RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@iravid @codecov-io @kailuowang @ceedubs