Add NonEmptyList.ofInitLast #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1910 +/- ##
==========================================
+ Coverage 95.54% 95.54% +<.01%
==========================================
Files 248 248
Lines 4418 4420 +2
Branches 126 124 -2
==========================================
+ Hits 4221 4223 +2
Misses 197 197
Continue to review full report at Codecov.
|
kailuowang
approved these changes
Sep 13, 2017
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mentioned this on gitter (thanks @edmundnoble for the name suggestion). I needed to build a NEL from an init list and a last element, and didn't like using
unsafeFromList. Not sure if it's generally useful but seems pretty natural given List'sinitandlastoperations.No worries if you think it's out of scope and don't want to include it.