Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to sbt 1.0 #1919

Merged
merged 9 commits into from
Jan 11, 2018
Merged

update to sbt 1.0 #1919

merged 9 commits into from
Jan 11, 2018

Conversation

kailuowang
Copy link
Contributor

@kailuowang kailuowang commented Sep 19, 2017

fixes #1848
I had to disable coursier
it's giving me

sbt:Cats core> compile
[error] scala.MatchError: Patch() (of class sbt.librarymanagement.Patch)
[error] at coursier.FromSbt$.sbtCrossVersionName(FromSbt.scala:31)
[error] at coursier.FromSbt$.sbtModuleIdName(FromSbt.scala:21)
[error] at coursier.FromSbt$.moduleVersion(FromSbt.scala:47)
[error] at coursier.FromSbt$.dependencies(FromSbt.scala:63)
...

Update: Coursier fixed.

@@ -1 +1 @@
sbt.version=0.13.16
sbt.version=1.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be 1.0.1 :)

@codecov-io
Copy link

codecov-io commented Sep 19, 2017

Codecov Report

Merging #1919 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1919   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files         328      328           
  Lines        5533     5533           
  Branches      199      199           
=======================================
  Hits         5238     5238           
  Misses        295      295

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a04fff...4fe6530. Read the comment docs.

@fthomas
Copy link
Member

fthomas commented Sep 19, 2017

The 2.10 build failed with

sbt.librarymanagement.ResolveException: unresolved dependency: org.tpolecat#tut-core_2.10;0.6.0: not found

because tut 0.6.0 is not available for 2.10. This has already been fixed in tut 0.6.1 (see tpolecat/tut#180). So sbt-microsites needs to depend on tut 0.6.1 instead of 0.6.0.

@ceedubs
Copy link
Contributor

ceedubs commented Sep 20, 2017

I see that Coursier 1.0.0-RC12 has already been released with a fix for the patch issue. @kailuowang should we try that out instead of disabling Coursier?

@fthomas
Copy link
Member

fthomas commented Sep 20, 2017

👍

I'm okay with merging this right now, but I think sbt/sbt#3427 means that we won't be able to publish for 2.13.0-M2 (see #1648) with this sbt version. /cc @BennyHill

@kailuowang
Copy link
Contributor Author

@ceedubs shall we merge this for now? the effort to support 2.13.0-M2 is put on hold right now.

@tpolecat
Copy link
Member

tpolecat commented Sep 26, 2017

sbt 1.0 is unusably slow on MacOS because there is no native file watcher, so I would prefer to wait on this until they have a fix for that issue (which I can't find). I upgraded doobie and immediately reverted it for this reason.

@kailuowang
Copy link
Contributor Author

blocked due to slowness of sbt 1.0 on MacOS

@tpolecat
Copy link
Member

The sbt issue is sbt/sbt#3527 … now seen on Arch apparently.

@kailuowang
Copy link
Contributor Author

kailuowang commented Jan 11, 2018

unblocked since sbt 1.0.3 reverted back to polling mode by default for MacOS.

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@kailuowang kailuowang merged commit 65d5933 into typelevel:master Jan 11, 2018
@kailuowang kailuowang deleted the sbt-1 branch January 11, 2018 12:13
@kailuowang kailuowang added this to the 1.1 milestone Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preparations for sbt 1.0.0
7 participants