Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax for ApplicativeError.fromEither #1933

Merged
merged 1 commit into from
Sep 26, 2017

Conversation

tpolecat
Copy link
Member

This adds syntax for ApplicativeError.fromEither as discussed on gitter.

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

codecov-io commented Sep 26, 2017

Codecov Report

Merging #1933 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1933      +/-   ##
==========================================
+ Coverage   95.55%   95.55%   +<.01%     
==========================================
  Files         248      248              
  Lines        4430     4431       +1     
  Branches      116      116              
==========================================
+ Hits         4233     4234       +1     
  Misses        197      197
Impacted Files Coverage Δ
core/src/main/scala/cats/syntax/either.scala 99.13% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc8637d...4c1436b. Read the comment docs.

@peterneyens peterneyens merged commit 9123be0 into typelevel:master Sep 26, 2017
@johnynek
Copy link
Contributor

nit: I would probably have rather this been pureOrRaise since the Or is usually used in to represent the failure case (at least thinking of Option[T]).

@kailuowang kailuowang added this to the 1.0.0-RC1 milestone Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants