Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add traverseN to cartesian syntax #1942

Merged
merged 1 commit into from
Sep 30, 2017
Merged

add traverseN to cartesian syntax #1942

merged 1 commit into from
Sep 30, 2017

Conversation

julien-truffaut
Copy link
Contributor

No description provided.

@kailuowang
Copy link
Contributor

Shall we change title to "add traverseN to cartesian syntax", which is what it does. CartesianBuilder is deprecated.

@julien-truffaut julien-truffaut changed the title add traverseN to CartesianBuilder add traverseN to cartesian syntax Sep 29, 2017
@julien-truffaut
Copy link
Contributor Author

I am not sure what does it mean:

[error] /home/travis/build/typelevel/cats/tests/src/test/scala/cats/tests/SyntaxTests.scala:147: discarded non-Unit value
[error]     (fa, fb, fc) traverseN ft

val ft = mock[(A, B, C) => G[Z]]

tfabc traverseN ft
(fa, fb, fc) traverseN ft
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either add a () at the end of the method or make it a statement by adding a val blah = (fa, fb, fc) traverseN ft which is a ()

@codecov-io
Copy link

codecov-io commented Sep 30, 2017

Codecov Report

Merging #1942 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1942      +/-   ##
==========================================
+ Coverage   95.57%   95.61%   +0.04%     
==========================================
  Files         248      248              
  Lines        4454     4519      +65     
  Branches      117      120       +3     
==========================================
+ Hits         4257     4321      +64     
- Misses        197      198       +1
Impacted Files Coverage Δ
core/src/main/scala/cats/data/EitherT.scala 98.36% <0%> (ø) ⬆️
core/src/main/scala/cats/syntax/alternative.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/Alternative.scala 90.9% <0%> (+2.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a68c80b...add2a1a. Read the comment docs.

@kailuowang kailuowang merged commit 0e33b29 into master Sep 30, 2017
@LukaJCB LukaJCB deleted the traverseN branch September 30, 2017 16:43
@kailuowang kailuowang added this to the 1.0.0-RC1 milestone Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants