Add FlatMap#flatTap, a more principled version of the kestrel combinator. #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnynek
reviewed
Oct 9, 2017
core/src/main/scala/cats/Monad.scala
Outdated
| * res3: List[Int] = List(4, 4, 4, 4) | ||
| * }}} | ||
| */ | ||
| def tapM[A, B](fa: F[A])(f: A => F[B]): F[A] = |
There was a problem hiding this comment.
can't this be on FlatMap not Monad?
|
Oh. Yeah, I guess it can. Thanks!
|
Codecov Report
@@ Coverage Diff @@
## master #1958 +/- ##
==========================================
+ Coverage 96.14% 96.14% +<.01%
==========================================
Files 273 273
Lines 4535 4536 +1
Branches 114 119 +5
==========================================
+ Hits 4360 4361 +1
Misses 175 175
Continue to review full report at Codecov.
|
kailuowang
previously approved these changes
Oct 10, 2017
|
I vote for |
johnynek
reviewed
Oct 10, 2017
| * res1: Char = 'a' | ||
| * }}} | ||
| * */ | ||
| def forEffect[A, B](fa: F[A])(fb: F[B]): F[A] = tapM(fa)(_ => fb) |
There was a problem hiding this comment.
There is another PR in flight to move this to a Apply. I don’t think we need tapM here. Can we revert this change?
…tor. It's a useful way of adding side-effects (as in, effects on the side) of a monadic (flatMappish?) computation.
|
Cool. That's two for the |
hrhino
changed the title
kailuowang
approved these changes
Oct 10, 2017
LukaJCB
approved these changes
Oct 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a useful way of adding side-effects (as in, effects on the side) of a monadic computation.
I almost called it
flatTap; I welcome opinions for or against either name.