Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduced usage of fold in Validated #1976

Merged
merged 2 commits into from
Oct 17, 2017
Merged

reduced usage of fold in Validated #1976

merged 2 commits into from
Oct 17, 2017

Conversation

kailuowang
Copy link
Contributor

fixes #1951

@kailuowang kailuowang changed the title reduced usage of fold in validated reduced usage of fold in Validated Oct 16, 2017
@codecov-io
Copy link

codecov-io commented Oct 16, 2017 •
edited
Loading

Codecov Report

Merging #1976 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1976      +/-   ##
==========================================
+ Coverage   96.08%   96.09%   +0.01%     
==========================================
  Files         273      273              
  Lines        4541     4554      +13     
  Branches      119      129      +10     
==========================================
+ Hits         4363     4376      +13     
  Misses        178      178
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Validated.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 167d5b4...6872179. Read the comment docs.

LukaJCB
LukaJCB approved these changes Oct 16, 2017
View reviewed changes
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks, LGTM! :)

@johnynek
Copy link
Contributor

👍

@kailuowang kailuowang merged commit d7a0204 into typelevel:master Oct 17, 2017
@kailuowang kailuowang added this to the 1.0.0-RC1 milestone Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaJCB LukaJCB LukaJCB approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.0.0-RC1
Development

Successfully merging this pull request may close these issues.

Reconsider the use of fold in Validated
4 participants
@kailuowang @codecov-io @johnynek @LukaJCB