Add parallel docs #2031
Merged
Add parallel docs #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I squashed the other pr, you might need to Cherry pick this one. |
|
Yeah I'll do that soonish :) |
LukaJCB
force-pushed
the
add-parallel-docs
branch
from
4f57f66
to
d0d19f5
Compare
LukaJCB
force-pushed
the
add-parallel-docs
branch
from
d0d19f5
to
08715e8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2031 +/- ##
=========================================
- Coverage 95.25% 95% -0.25%
=========================================
Files 305 311 +6
Lines 5179 5266 +87
Branches 127 131 +4
=========================================
+ Hits 4933 5003 +70
- Misses 246 263 +17
Continue to review full report at Codecov.
|
kailuowang
previously approved these changes
Nov 24, 2017
ceedubs
previously approved these changes
Nov 27, 2017
| ## NonEmptyParallel - a weakened Parallel | ||
|
|
||
| If you recall that some types cannot form a `Monad` or an `Applicative` because it's not possible to implement the `pure` function for them. | ||
| However, these types usually can have instances for `FlatMap` or `Apply`. |
There was a problem hiding this comment.
2 minor comments:
- This might read a little more cleanly if you drop the "If you recall that". That is, it could start with "Some types cannot...".
- "usually" might be an overly strong assertion here. Maybe just say "often"?
kailuowang
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some documentation for the new
Parallelclass. Right now it depends on #1938. We should be able to give more examples once we have aParallelinstance forcats.effect.IO:)