CommutativeMonoid instance for SortedMap #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll need to add an exception Mima exception, but otherwise this looks great, thank you! |
johnynek
previously approved these changes
Nov 26, 2017
Codecov Report
@@ Coverage Diff @@
## master #2047 +/- ##
==========================================
+ Coverage 95.07% 95.07% +<.01%
==========================================
Files 311 311
Lines 5255 5256 +1
Branches 121 126 +5
==========================================
+ Hits 4996 4997 +1
Misses 259 259
Continue to review full report at Codecov.
|
LukaJCB
approved these changes
Nov 26, 2017
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
CommutativeMonoidinstance forSortedMapwhen there is aCommutativeSemigroupinstance for the value type.Besides adding a test for
CommutativeMonoid[SortedMap[String, Int]], I also modified the test forMonoid[SortedMap[String, Int]]to be aMonoid[SortedMap[String, String]], such that I can ensure that theMonoidinstance can still be resolved when there is not aCommutativeSemigroupfor the value type.