-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a default id for Arrow #2072
Conversation
we already have a law ``` F.lift(identity[A]) <-> F.id[A] ``` so it's hard to see why this shouldn't be given as a default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming build passes
Codecov Report
@@ Coverage Diff @@
## master #2072 +/- ##
==========================================
- Coverage 94.66% 94.66% -0.01%
==========================================
Files 318 318
Lines 5383 5419 +36
Branches 207 208 +1
==========================================
+ Hits 5096 5130 +34
- Misses 287 289 +2
Continue to review full report at Codecov.
|
we already have a law
so it's hard to see why this shouldn't be given as a default.