Reduce redundancy in Semigroup and Eq test names #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if you ran the `CommutativeSemigroup` tests on a type (`Mean` in this example) you would see something like: ``` MeanTests: - Mean.commutativeSemigroup.commutative - Mean.commutativeSemigroup.semigroup associative - Mean.commutativeSemigroup.semigroup combineAllOption - Mean.commutativeSemigroup.semigroup repeat1 - Mean.commutativeSemigroup.semigroup repeat2 ``` The extra `semigroup` in the name seems redundant to me, and as far as I can tell, it's inconsistent with tests for other type classes. `Eq` had a similar issue.
LukaJCB
approved these changes
Dec 8, 2017
Codecov Report
@@ Coverage Diff @@
## master #2081 +/- ##
==========================================
- Coverage 94.66% 94.63% -0.04%
==========================================
Files 318 318
Lines 5383 5383
Branches 207 207
==========================================
- Hits 5096 5094 -2
- Misses 287 289 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you ran the
CommutativeSemigrouptests on a type (Meanin this example) you would see something like:
The extra
semigroupin the name seems redundant to me, and as far as Ican tell, it's inconsistent with tests for other type classes.
Eqhada similar issue.