Some Kleisli instance cleanup #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove an irrelevant and unused `B` type parameter on `catsDataCommutativeMonadForKleisli`. - Upgrade `catsDataMonadForKleisliId` from `Monad` to `CommutativeMonad` - Note that while I had to add a mima exception for this, I think that it should be 100% binary compatible since its a member of a `sealed` and `private` abstract class and returns a subtype of what it was before. - Add a `CommutativeFlatMap` instance for `Kleisli` - Add a couple of implicit resolution tests for Kleisli that were missing
kailuowang
approved these changes
Dec 14, 2017
LukaJCB
approved these changes
Dec 14, 2017
johnynek
approved these changes
Dec 14, 2017
Codecov Report
@@ Coverage Diff @@
## master #2105 +/- ##
=========================================
Coverage ? 94.79%
=========================================
Files ? 325
Lines ? 5494
Branches ? 219
=========================================
Hits ? 5208
Misses ? 286
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Btype parameter oncatsDataCommutativeMonadForKleisli.catsDataMonadForKleisliIdfromMonadtoCommutativeMonadit should be 100% binary compatible since its a member of a
sealedand
privateabstract class and returns a subtype of what it wasbefore.
CommutativeFlatMapinstance forKleislimissing