Set micrositeDocumentationUrl as root-relative #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Info related to this can be found on 47degrees/sbt-microsites#251
Codecov Report
@@ Coverage Diff @@
## master #2140 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 328 328
Lines 5533 5533
Branches 199 199
=======================================
Hits 5238 5238
Misses 295 295Continue to review full report at Codecov.
|
kailuowang
approved these changes
Jan 13, 2018
LukaJCB
approved these changes
Jan 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is due to to the documentation URL not being properly formed depending on the base href. By setting it as root-relative, we can be totally sure where we are pointing the link to.
Info related to this can be found on 47degrees/sbt-microsites#251