-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split build jvm,add workers to kernel #2189
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2189 +/- ##
==========================================
- Coverage 94.75% 94.73% -0.03%
==========================================
Files 330 330
Lines 5568 5582 +14
Branches 201 207 +6
==========================================
+ Hits 5276 5288 +12
- Misses 292 294 +2
Continue to review full report at Codecov.
|
build.sbt
Outdated
|
||
addCommandAlias("buildTestingJVM", ";kernelLawsJVM/test;lawsJVM/test;testkitJVM/test;testsJVM/test") | ||
|
||
addCommandAlias("buildJVM", ";macrosJVM/test;kernelJVM/test;buildTestingJVM;jvm/test;coreJVM/test;freeJVM/test;buildAlleycatsJVM") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry to nitpick, but this gets harder for me to track what's included in what. maybe we break out a "buildKernelJVM" and a "buildFreeJVM" too for the sake of a clearer structure? Just a thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh. I originally had:
-addCommandAlias("buildJVM", ";macrosJVM/test;kernelJVM/test;kernelLawsJVM/test;lawsJVM/test;testkitJVM/test;testsJVM/test;jvm/test;coreJVM/test;freeJVM/test;alleycatsCoreJVM/test;alleycatsLawsJVM/test;alleycatsTestsJVM/test")
Ha! Not a problem to break up more, it's more confusing than it should be whatever we do, so I thought I should PR something to get some thoughts. I'll update it now.
Those two codecov are from #2182, merged two hours ago |
seems fine to me, but does not seem to have sped up the build. was there another goal? |
Speed was not the issue, rather OOM in CI - eg see https://travis-ci.org/BennyHill/cats/jobs/352007704 and chat in gitter before and after https://gitter.im/typelevel/cats-dev?at=5aa55b886f8b4b994614b5c0 Original chat: https://gitter.im/typelevel/cats?at=5a99c17235dd17022e141d21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also tweaked the cache in travis, including
- $HOME/.cache
for javascript build artifacts