Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check MonadTests for Vector and List #2214

Merged
merged 1 commit into from
Mar 25, 2018

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Mar 25, 2018

This is surprising to me, so I may be missing something, but as far as I
can tell, we weren't running the MonadTests for Vector and List.

This is surprising to me, so I may be missing something, but as far as I
can tell, we weren't running the MonadTests for Vector and List.
Copy link
Contributor

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG.

Maybe we should do a push to see what code is not covered by tests to see if we can more such examples.

@ceedubs
Copy link
Contributor Author

ceedubs commented Mar 25, 2018

Indeed the way that I discovered this was by noticing that tailRecM for Vector didn't have coverage.

@codecov-io
Copy link

Codecov Report

Merging #2214 into master will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2214     +/-   ##
=========================================
+ Coverage   94.83%   95.04%   +0.2%     
=========================================
  Files         333      333             
  Lines        5789     5789             
  Branches      211      211             
=========================================
+ Hits         5490     5502     +12     
+ Misses        299      287     -12
Impacted Files Coverage Δ
core/src/main/scala/cats/instances/vector.scala 100% <0%> (+27.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f3ea43...a4e15ff. Read the comment docs.

@ceedubs ceedubs merged commit f038f0c into typelevel:master Mar 25, 2018
@ceedubs ceedubs deleted the vector-monad-tests branch March 25, 2018 20:38
@kailuowang kailuowang added this to the 1.2 milestone May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants