Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update state.md #2248

Merged
merged 2 commits into from
Jun 11, 2018
Merged

Update state.md #2248

merged 2 commits into from
Jun 11, 2018

Conversation

rsekulski
Copy link
Contributor

I think functions open and close were swapped in section about IndexedStateT.

I think functions `open` and `close` were swapped in section about `IndexedStateT`.
@codecov-io
Copy link

codecov-io commented May 6, 2018

Codecov Report

Merging #2248 into master will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2248      +/-   ##
==========================================
+ Coverage   94.65%   94.97%   +0.32%     
==========================================
  Files         333      337       +4     
  Lines        5777     5832      +55     
  Branches      217      217              
==========================================
+ Hits         5468     5539      +71     
+ Misses        309      293      -16
Impacted Files Coverage Δ
.../src/main/scala/cats/syntax/applicativeError.scala 100% <0%> (ø) ⬆️
...rc/main/scala/cats/laws/discipline/Arbitrary.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/syntax/option.scala 100% <0%> (ø) ⬆️
laws/src/main/scala/cats/laws/MonadLaws.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/syntax/nested.scala 100% <0%> (ø)
core/src/main/scala/cats/syntax/binested.scala 100% <0%> (ø)
core/src/main/scala/cats/data/Binested.scala 100% <0%> (ø)
core/src/main/scala/cats/data/Op.scala 87.5% <0%> (ø)
core/src/main/scala/cats/data/Ior.scala 98.48% <0%> (+0.01%) ⬆️
core/src/main/scala/cats/data/Kleisli.scala 96.93% <0%> (+0.03%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b163e77...967c869. Read the comment docs.

Copy link
Contributor

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the tut to actually catch this error? Like it we had run open against an Open door, it should have failed. Can we add positive and negative examples of that now and make sure tut catches the issue?

@kailuowang kailuowang added this to the 1.2 milestone May 30, 2018
ceedubs
ceedubs previously approved these changes May 30, 2018
Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @johnynek that changing the tut doc to catch this would be better. But fixing the typo is still an improvement.

@rsekulski
Copy link
Contributor Author

I'm really sorry for such late response. I've added code which tries to run valid with both Open and Closed to demonstrate type safety.

@ceedubs ceedubs merged commit 4aafba2 into typelevel:master Jun 11, 2018
@ceedubs
Copy link
Contributor

ceedubs commented Jun 11, 2018

Thanks @rsekulski!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants