-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update state.md #2248
Update state.md #2248
Conversation
I think functions `open` and `close` were swapped in section about `IndexedStateT`.
Codecov Report
@@ Coverage Diff @@
## master #2248 +/- ##
==========================================
+ Coverage 94.65% 94.97% +0.32%
==========================================
Files 333 337 +4
Lines 5777 5832 +55
Branches 217 217
==========================================
+ Hits 5468 5539 +71
+ Misses 309 293 -16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the tut to actually catch this error? Like it we had run open against an Open door, it should have failed. Can we add positive and negative examples of that now and make sure tut catches the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @johnynek that changing the tut doc to catch this would be better. But fixing the typo is still an improvement.
I'm really sorry for such late response. I've added code which tries to run |
Thanks @rsekulski! |
I think functions
open
andclose
were swapped in section aboutIndexedStateT
.