Merge 1.2.x back to master #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use portable-scala crossProject * Refine POM match for simulacrum
* drop 2.10 support from the build * drop Scala 2.10 /update to 2.13-M3
LukaJCB
approved these changes
Jul 26, 2018
Codecov Report
@@ Coverage Diff @@
## master #2338 +/- ##
=======================================
Coverage 95.09% 95.09%
=======================================
Files 345 345
Lines 5991 5991
Branches 219 219
=======================================
Hits 5697 5697
Misses 294 294Continue to review full report at Codecov.
|
|
Since this is a merge branch PR (all the code changes are already approved before), I am going to merge with one approval. |
|
sorry I accidentally squashed. Let me revert and try again. |
kailuowang
added a commit
that referenced
this pull request
Jul 26, 2018
This reverts commit 39125b5.
kailuowang
added a commit
that referenced
this pull request
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this drops Scala 2.10. And the "update to 2.13.0-M4" is merely a version update (still allowing build failure on 2.13), the actual work to update cats to support 2.13 is in progress in this #2335