Add parTraverse_ and parSequence_ syntax #2341 #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2351 +/- ##
==========================================
+ Coverage 95.09% 95.09% +<.01%
==========================================
Files 345 345
Lines 5991 5995 +4
Branches 219 219
==========================================
+ Hits 5697 5701 +4
Misses 294 294
Continue to review full report at Codecov.
|
kailuowang
reviewed
Aug 3, 2018
| @@ -40,6 +54,12 @@ final class ParallelSequenceOps[T[_], M[_], A](val tma: T[M[A]]) extends AnyVal | |||
| Parallel.parSequence(tma) | |||
| } | |||
|
|
|||
| final class ParallelSequence_Ops[T[_], M[_], A](val tma: T[M[A]]) extends AnyVal { | |||
There was a problem hiding this comment.
Totally nitpicking, the _ in the class name is a bit unconventional in this code base. Normally it wouldn't be a big deal, we could always change it after, but we can't really in cats....
There was a problem hiding this comment.
I kind of agree, but couldn't come up with a better name. Any suggestions?
There was a problem hiding this comment.
My apologies, didn't realize it's coming from the method name.
kailuowang
approved these changes
Aug 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2341