Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definition of point-wise to README #2512

Merged
merged 1 commit into from
Sep 29, 2018
Merged

Add definition of point-wise to README #2512

merged 1 commit into from
Sep 29, 2018

Conversation

AaronDelaplane
Copy link

@AaronDelaplane AaronDelaplane commented Sep 18, 2018

First, thank you for the wonderful libraries and documentation.

When reading the documentation I did not know what "point-wise" meant. A quick Google search produced mathematical explanations that were a bit over my head. I posted a question on the chat channel and @SystemFw provided a clear definition that I've included in this PR.

Perhaps others will not know what "point-wise" means and this addition will help them proceed with a little more understanding as they are working through the documentation.

It is kind of a long addition. I certainly understand if you'd like to keep the docs lean and pass on this PR.

Thanks for all the hard work.

Copy link
Contributor

@easel easel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The travis failure looks spurious to me.

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @AaronDelaplane! Great change. I've restarted the build that seemed to have a spurious failure.

@codecov-io
Copy link

Codecov Report

Merging #2512 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2512   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files         357      357           
  Lines        6528     6528           
  Branches      281      281           
=======================================
  Hits         6227     6227           
  Misses        301      301

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1911e8b...4a78afb. Read the comment docs.

@LukaJCB LukaJCB merged commit 0a377a3 into typelevel:master Sep 29, 2018
@kailuowang kailuowang added this to the 1.5 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants