Add NonEmptyMap#toNonEmptyList (issue #2346) #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaJCB
reviewed
Sep 26, 2018
|
|
||
| test("NonEmptyMap#toNonEmptyList is consistent with Map#toList and creating NonEmptyList from it"){ | ||
| forAll{ nem: NonEmptyMap[String, Int] => | ||
| nem.toNonEmptyList should ===(NonEmptyList.fromListUnsafe(nem.toSortedMap.toList)) |
There was a problem hiding this comment.
Unfortunately the toNonEmptyList of NonEmptyMap collides with toNonEmptyList of Reducible, so the nem.toNonEmptyList here seems to return a NonEmptyList[Int] instead of the NonEmptyList[(String, Int)] that we want.
Maybe we should rename the method to toNel instead? :)
There was a problem hiding this comment.
Worked, thanks a lot!
CucumisSativus
force-pushed
the
nem-to-nel
branch
from
1daf808
to
66d8957
Compare
LukaJCB
approved these changes
Sep 26, 2018
kailuowang
approved these changes
Sep 27, 2018
Codecov Report
@@ Coverage Diff @@
## master #2535 +/- ##
==========================================
+ Coverage 95.18% 95.19% +<.01%
==========================================
Files 360 360
Lines 6548 6549 +1
Branches 279 275 -4
==========================================
+ Hits 6233 6234 +1
Misses 315 315
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this is my first pull request there so please go easy with me :)
As for #2346 started with small steps - implementing just first method. Frankly i have no idea if I placed this in proper place, no idea if my test is sufficient and no idea if the thing I implemented is performant and if my git message is sufficient. Would love any feedback from you. Then after initial feedback I will do my best to implement rest of the methods from that issue