Add an applyK function to Kleisli.
#2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kailuowang
reviewed
Oct 18, 2018
peterneyens
reviewed
Oct 23, 2018
|
@diesalbla are you still interested in fixing the doctest? |
|
@kailuowang @peterneyens Fixed the doctests, and used |
|
Oh we can't add it the trait without breaking Binary compatibility, make just add it to the companion |
|
Did you mean the |
|
Yup |
We add an `applyK` function to the `Kleisli` companion object. This takes a parameter of type `A`, and generates a natural transformation (`FunctionK`) from `Kleisli[F,A,?]` to `F`, i.e., it maps over the kleisli by applying it to the given parameter.
Codecov Report
@@ Coverage Diff @@
## master #2563 +/- ##
==========================================
+ Coverage 95.16% 95.16% +<.01%
==========================================
Files 365 365
Lines 6777 6778 +1
Branches 302 294 -8
==========================================
+ Hits 6449 6450 +1
Misses 328 328
Continue to review full report at Codecov.
|
LukaJCB
approved these changes
Jan 13, 2019
kailuowang
approved these changes
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add an
applyKfunction to theKleislicompanion object. This takes a parameter of typeA, and generates a natural transformation (FunctionK) fromKleisli[F,A,?]toF, i.e., it maps over the Kleisli object by applying it to the given parameter.An alternative name for this function could be
dipK, or something that conveys the idea of it being contrary to theliftKfunction.