-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add updateWith
method to NonEmptyMap
#2592
Add updateWith
method to NonEmptyMap
#2592
Conversation
Build is flaky? Seems to have died with OOM for Scala 2.13... |
Codecov Report
@@ Coverage Diff @@
## master #2592 +/- ##
==========================================
+ Coverage 95.16% 95.16% +<.01%
==========================================
Files 361 361
Lines 6634 6637 +3
Branches 294 290 -4
==========================================
+ Hits 6313 6316 +3
Misses 321 321
Continue to review full report at Codecov.
|
Can you add |
Thanks @nasadorian! This looks good to me, but I don't think that the tests are hitting the case where the key isn't in the map. Could you explicitly test that case? It could probably be a unit test and/or an sbt-doctest example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks, @nasadorian!
updateWith
sinceupdated
would imply a simple setting of k -> vCloses #2288