Cleaning up docs to no longer use fine grained imports #2664
Conversation
| @@ -212,8 +212,7 @@ This function is provided by Cats via the `Traverse[List]` instance and syntax, | |||
| tutorial. | |||
|
|
|||
| ```tut:book:silent | |||
| import cats.instances.list._ | |||
| import cats.syntax.traverse._ | |||
| import cats.implicits | |||
There was a problem hiding this comment.
Did this miss the ._?
There was a problem hiding this comment.
oops, missed that, I will fix that in a separate PR.
There was a problem hiding this comment.
Why didn't this broke the build?
There was a problem hiding this comment.
the import isn't really needed for the code since it's already imported at previous blocks. I guess unused import isn't checked in tut.
There was a problem hiding this comment.
If it is not needed I'd remove it or require that each paragraph needs to specify its imports again with maybe tut's :reset modifier.
There was a problem hiding this comment.
I read the page again and I can see all these imports are confusing. It looks like it would be cumbersome to reset every paragraph.
I suggested that we remove import cats.implicits._ from them and add it to the top of the page, with something like:
First, bring cats instances into the scope by
import cats.implicits._
#2651
@LukaJCB @tpolecat
How does this look to you guys? Hopefully I got them all, happy to take another sweep through if you know of any I missed.