Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add method on object CommutativeApplicative to get CommutativeMonoid #2747

Merged
merged 2 commits into from
Mar 15, 2019
Merged

add method on object CommutativeApplicative to get CommutativeMonoid #2747

merged 2 commits into from
Mar 15, 2019
+34 −0

Conversation

alexeygorobets
Copy link
Contributor

Close #2716

@codecov-io
Copy link

codecov-io commented Mar 9, 2019 •
edited
Loading

Codecov Report

Merging #2747 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2747      +/-   ##
==========================================
+ Coverage   95.33%   95.34%   +<.01%     
==========================================
  Files         363      363              
  Lines        6777     6782       +5     
  Branches      299      290       -9     
==========================================
+ Hits         6461     6466       +5     
  Misses        316      316
Impacted Files Coverage Δ
core/src/main/scala/cats/CommutativeApply.scala 66.66% <100%> (+66.66%) ⬆️
...e/src/main/scala/cats/CommutativeApplicative.scala 75% <100%> (+75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab04cf...3a73063. Read the comment docs.

kailuowang
kailuowang approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kailuowang kailuowang merged commit 31f9f1e into typelevel:master Mar 15, 2019
@kailuowang kailuowang added this to the 2.0 milestone Mar 15, 2019
@rossabaker rossabaker mentioned this pull request May 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaJCB LukaJCB LukaJCB approved these changes

@kailuowang kailuowang kailuowang approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0.0-M1
Development

Successfully merging this pull request may close these issues.
4 participants
@alexeygorobets @codecov-io @kailuowang @LukaJCB