Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a styling stage to check the styles first #2752

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

kailuowang
Copy link
Contributor

@kailuowang kailuowang commented Mar 19, 2019

before committing to run the full build.

before committing to run the full build.
@codecov-io
Copy link

Codecov Report

Merging #2752 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2752      +/-   ##
==========================================
- Coverage   95.34%   95.32%   -0.02%     
==========================================
  Files         363      363              
  Lines        6782     6783       +1     
  Branches      290      290              
==========================================
  Hits         6466     6466              
- Misses        316      317       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31f9f1e...fd923a6. Read the comment docs.

script: |
if [[ $(cat version.sbt) =~ "-SNAPSHOT" ]]; then
sbt ++$TRAVIS_SCALA_VERSION! publish gitSnapshots publish
sbt +publish gitSnapshots +publish
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes it possible for each module to define which scala version to release on (based on their own crossScalaVersions), also simplifies the build here.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea 👍

@kailuowang
Copy link
Contributor Author

@ceedubs , do you happen to have time to take a look? You mentioned something about Travis stage not working in some way. This run seems fine to me. Maybe they fixed it?

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍.

The reason that I didn't go down this path is that I think that it slightly slows down the overall build time (because the longest-running tasks can't start right away). But that may be worth it to have builds fail quickly for trivial errors.

@kailuowang kailuowang merged commit 56a1339 into master Mar 27, 2019
@kailuowang
Copy link
Contributor Author

Yes. That occurred to me as well. Since all cats PRs/branch build share the same concurrent VMs, I think it's worth the little delay to free up VMs for other PRs.

@kailuowang kailuowang added this to the 2.0.0-M1 milestone Apr 18, 2019
@kailuowang kailuowang deleted the kailuowang-patch-1 branch June 10, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants