-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a styling stage to check the styles first #2752
Conversation
before committing to run the full build.
Codecov Report
@@ Coverage Diff @@
## master #2752 +/- ##
==========================================
- Coverage 95.34% 95.32% -0.02%
==========================================
Files 363 363
Lines 6782 6783 +1
Branches 290 290
==========================================
Hits 6466 6466
- Misses 316 317 +1 Continue to review full report at Codecov.
|
script: | | ||
if [[ $(cat version.sbt) =~ "-SNAPSHOT" ]]; then | ||
sbt ++$TRAVIS_SCALA_VERSION! publish gitSnapshots publish | ||
sbt +publish gitSnapshots +publish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes it possible for each module to define which scala version to release on (based on their own crossScalaVersions
), also simplifies the build here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea 👍
@ceedubs , do you happen to have time to take a look? You mentioned something about Travis stage not working in some way. This run seems fine to me. Maybe they fixed it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍.
The reason that I didn't go down this path is that I think that it slightly slows down the overall build time (because the longest-running tasks can't start right away). But that may be worth it to have builds fail quickly for trivial errors.
Yes. That occurred to me as well. Since all cats PRs/branch build share the same concurrent VMs, I think it's worth the little delay to free up VMs for other PRs. |
before committing to run the full build.