Fix our crossScalaVersions since the last change to travis.yml #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avis file using a different scala setting
kailuowang
commented
Apr 2, 2019
| @@ -743,7 +765,7 @@ addCommandAlias("validateKernelJS", "kernelLawsJS/test") | |||
| addCommandAlias("validateFreeJS", "freeJS/test") //separated due to memory constraint on travis | |||
| addCommandAlias("validate", ";clean;validateJS;validateKernelJS;validateFreeJS;validateJVM") | |||
|
|
|||
| addCommandAlias("prePR", ";fmt;++2.11.12;validateBC") | |||
| addCommandAlias("prePR", ";fmt;++2.11.12 mimaReportBinaryIssues") | |||
There was a problem hiding this comment.
unfortunately, sbt doesn't seem to work when trying to fix to a scala version when running a command alias.
I filed an issue sbt/sbt#4599
by this change we no longer run binCompatTest/test, but I think it's rare that it's accidentally broken before PR.
ceedubs
approved these changes
Apr 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #2771 +/- ##
=======================================
Coverage 95.34% 95.34%
=======================================
Files 363 363
Lines 6785 6785
Branches 283 283
=======================================
Hits 6469 6469
Misses 316 316Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sbt-travisci plugin was no longer able to parse travis.yml since we move away from build matrix. This, combined with other changes made to the build, broke
sbt prePRas well snapshot release