Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unconventional package objects in kernel #2785

Merged
merged 3 commits into from
Apr 11, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package cats.kernel
package instances

trait EqInstances extends EqToEquivConversion
package object eq extends EqInstances

object eq extends EqInstances
trait EqInstances extends EqToEquivConversion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this change is necessary

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package cats.kernel
package instances

trait HashInstances extends HashToHashingConversion
package object hash extends HashInstances

object hash extends HashInstances
trait HashInstances extends HashToHashingConversion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here. the original is fine IMO

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package cats.kernel
package instances

trait OrderInstances extends OrderToOrderingConversion
package object order extends OrderInstances

object order extends OrderInstances
trait OrderInstances extends OrderToOrderingConversion
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package cats.kernel
package instances

trait PartialOrderInstances extends PartialOrderToPartialOrderingConversion
package object partialOrder extends PartialOrderInstances // scalastyle:ignore package.object.name

object partialOrder extends PartialOrderInstances
trait PartialOrderInstances extends PartialOrderToPartialOrderingConversion