Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed export hook #2794

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Conversation

kailuowang
Copy link
Contributor

export hook seems to be blocking updating to 2.13.0-RC1 #2792

@codecov-io
Copy link

codecov-io commented Apr 16, 2019

Codecov Report

Merging #2794 into master will decrease coverage by 0.4%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2794      +/-   ##
==========================================
- Coverage   94.68%   94.28%   -0.41%     
==========================================
  Files         365      367       +2     
  Lines        6869     6926      +57     
  Branches      293      297       +4     
==========================================
+ Hits         6504     6530      +26     
- Misses        365      396      +31
Impacted Files Coverage Δ
...eycats-core/src/main/scala/alleycats/std/map.scala 46.42% <ø> (ø) ⬆️
...leycats-core/src/main/scala/alleycats/EmptyK.scala 0% <ø> (ø) ⬆️
...eycats-core/src/main/scala/alleycats/Extract.scala 0% <ø> (ø) ⬆️
alleycats-core/src/main/scala/alleycats/Zero.scala 0% <ø> (ø) ⬆️
...eycats-core/src/main/scala/alleycats/std/try.scala 14.28% <ø> (+14.28%) ⬆️
...ats-core/src/main/scala/alleycats/std/option.scala 50% <ø> (ø)
...ycats-core/src/main/scala/alleycats/std/list.scala 50% <ø> (ø)
alleycats-core/src/main/scala/alleycats/One.scala 0% <ø> (ø) ⬆️
...s-core/src/main/scala/alleycats/std/iterable.scala 75% <ø> (-25%) ⬇️
...ats-core/src/main/scala/alleycats/std/future.scala 50% <ø> (+50%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60d2033...1df53b8. Read the comment docs.

@mpilquist mpilquist self-requested a review April 16, 2019 11:39
@LukaJCB
Copy link
Member

LukaJCB commented Apr 16, 2019

Thanks so much for taking care of this @kailuowang! Any objections to merge this ASAP? :)

@kailuowang
Copy link
Contributor Author

kailuowang commented Apr 16, 2019

Just noticed some glitch with kittens. Please give me some time to investigate. There is probably nothing we can do in this PR to address it. Let me verify.

Update, issue resolved in kittens, I am going to merge this.

@kailuowang kailuowang merged commit 65bee09 into typelevel:master Apr 16, 2019
@kailuowang kailuowang deleted the remove-export-hook branch April 16, 2019 16:07
@kailuowang kailuowang mentioned this pull request Apr 17, 2019
@kailuowang kailuowang added this to the 2.0 milestone Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants