Fix Order.max and Oder.min description comments #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed description to better fit their implentation
Codecov Report
@@ Coverage Diff @@
## master #2842 +/- ##
=======================================
Coverage 94.21% 94.21%
=======================================
Files 368 368
Lines 6944 6944
Branches 301 301
=======================================
Hits 6542 6542
Misses 402 402
Continue to review full report at Codecov.
|
kailuowang
approved these changes
May 16, 2019
rossabaker
approved these changes
May 25, 2019
rossabaker
pushed a commit
to rossabaker/cats
that referenced
this pull request
May 26, 2019
Changed description to better fit their implentation
rossabaker
added a commit
that referenced
this pull request
Jun 3, 2019
* Change MonadErrorOps#reject so it no longer runs effects twice (#2810) * Add regression test for MonadErrorOps bug * Change MonadErrorOps#reject so it no longer re-runs the effect it is called on. Fixes #2809 * Fix Order.max and Oder.min description comments (#2842) Changed description to better fit their implentation * Make WrappedMutableMapBase extend Serializable (#2784) We are running into Spark `Task not serializable` issues when a closure that executes on a Spark executor node involves a `Map` that is created via running `foldMap` on a `List`. This commit makes the `WrappedMutableMap` hierarchy extend `Serializable` and chex that the cerealization works (this test failed before extending `Serializable`). * Optimize productR in Apply (#2728)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed description to better fit their implementation:
maxis usinggtwhich is:>and not>=minis usingltwhich is:<and not<=