Don't create the hydra.license if $HydraLicense is empty #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sbt-hydra checks if a hydra.license file exists to decide whether it should enable itself. Therefore, if the $HydraLicense is empty, it's important not to create the hydra.license file. The reason why the $HydraLicense can be empty is because its content is a secret, hence it is available only to PRs created from within the repository. Otherwise, the secret would be easily leaked. This commit is a followup fix for 8069e09
Codecov Report
@@ Coverage Diff @@
## master #2858 +/- ##
=======================================
Coverage 94.21% 94.21%
=======================================
Files 368 368
Lines 6948 6948
Branches 307 308 +1
=======================================
Hits 6546 6546
Misses 402 402Continue to review full report at Codecov.
|
|
@dotta thanks for finding the fix. |
kailuowang
approved these changes
May 24, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sbt-hydra checks if a hydra.license file exists to decide whether it should enable
itself. Therefore, if the $HydraLicense is empty, it's important not to
create the hydra.license file.
The reason why the $HydraLicense can be empty is because its content is a
secret, hence it is available only to PRs created from within the repository.
Otherwise, the secret would be easily leaked.
This commit is a followup fix for 8069e09
I'm afraid the PR #2857 needs to include this fix to be validated. Sorry!
Please, don't hesitate to pull me and @dragos in if you hit any hurdle with Hydra.