Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross compile replace Stream with LazyList on Scala 2.13 #2904

Merged
merged 9 commits into from
Jun 21, 2019

Conversation

kailuowang
Copy link
Contributor

@kailuowang kailuowang commented Jun 20, 2019

  • Added LazyList as a type alias for Stream on Scala 2.12- to support cross compilation
  • Thanks to backward compatibility, most existing class/trait names remained as StreamXXXX.
  • Added instances for Scala2.13 LazyList (all the credit goes to @johnynek )

@codecov-io
Copy link

codecov-io commented Jun 20, 2019

Codecov Report

Merging #2904 into master will decrease coverage by 0.02%.
The diff coverage is 79.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2904      +/-   ##
==========================================
- Coverage    94.2%   94.17%   -0.03%     
==========================================
  Files         368      370       +2     
  Lines        6949     6952       +3     
  Branches      309      307       -2     
==========================================
+ Hits         6546     6547       +1     
- Misses        403      405       +2
Impacted Files Coverage Δ
...main/scala-2.12-/cats/kernel/compat/lazyList.scala 0% <0%> (ø)
...re/src/main/scala-2.12-/cats/compat/lazyList.scala 0% <0%> (ø)
.../scala/cats/kernel/instances/StreamInstances.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/instances/sortedSet.scala 100% <100%> (ø) ⬆️
...rc/main/scala/cats/laws/discipline/Arbitrary.scala 99.15% <100%> (ø) ⬆️
...e/src/main/scala-2.12-/cats/instances/stream.scala 97.26% <100%> (ø)
core/src/main/scala/cats/data/package.scala 88.88% <100%> (ø) ⬆️
core/src/main/scala/cats/instances/parallel.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/data/OneAnd.scala 95.94% <100%> (ø) ⬆️
core/src/main/scala/cats/data/ZipStream.scala 77.77% <50%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d822620...9f6fff6. Read the comment docs.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

Copy link
Contributor

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@kailuowang kailuowang merged commit 69fd74e into typelevel:master Jun 21, 2019
@kailuowang kailuowang deleted the compat-stream branch June 21, 2019 01:08
@kailuowang kailuowang added this to the 2.0.0-RC1 milestone Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants