Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all 2.13 warnings, reenabled fatalWarning on 2.13 #2914

Merged
merged 6 commits into from
Jun 27, 2019

Conversation

kailuowang
Copy link
Contributor

fix #2893

@codecov-io
Copy link

codecov-io commented Jun 27, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@207bb0d). Click here to learn what that means.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2914   +/-   ##
=========================================
  Coverage          ?   94.24%           
=========================================
  Files             ?      364           
  Lines             ?     6951           
  Branches          ?      191           
=========================================
  Hits              ?     6551           
  Misses            ?      400           
  Partials          ?        0
Impacted Files Coverage Δ
...rc/main/scala/cats/laws/discipline/Arbitrary.scala 99.15% <ø> (ø)
.../scala/cats/kernel/instances/StreamInstances.scala 100% <ø> (ø)
...n/scala/cats/kernel/instances/QueueInstances.scala 100% <ø> (ø)
...in/scala/cats/kernel/instances/ListInstances.scala 100% <ø> (ø)
core/src/main/scala/cats/Invariant.scala 90.47% <ø> (ø)
core/src/main/scala/cats/data/OneAnd.scala 95.94% <ø> (ø)
core/src/main/scala/cats/data/package.scala 88.88% <ø> (ø)
core/src/main/scala/cats/instances/parallel.scala 100% <ø> (ø)
.../scala/cats/kernel/instances/VectorInstances.scala 100% <ø> (ø)
...eycats-core/src/main/scala/alleycats/std/set.scala 51.16% <0%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 207bb0d...60dc3ad. Read the comment docs.

@kailuowang kailuowang added this to the 2.0.0-RC1 milestone Jun 27, 2019
@kailuowang kailuowang requested a review from LukaJCB June 27, 2019 02:09
@kailuowang kailuowang merged commit dbfcb36 into typelevel:master Jun 27, 2019
@kailuowang
Copy link
Contributor Author

We might want more reviews. Merged for now to unblock folks at Scala matsuri contribution event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix all compiler warnings on Scala 2.13
4 participants