Update "README.md" for Scala 2.13.0 compiler specification changing(a… #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bout partial unification). typelevel#2948
|
|
Codecov Report
@@ Coverage Diff @@
## master #2949 +/- ##
=======================================
Coverage 94.03% 94.03%
=======================================
Files 370 370
Lines 7038 7038
Branches 183 183
=======================================
Hits 6618 6618
Misses 420 420Continue to review full report at Codecov.
|
kailuowang
reviewed
Jul 18, 2019
README.md
Outdated
| @@ -67,12 +67,14 @@ Silver Sponsors are those who have pledged $2,000 to $5,000. | |||
|
|
|||
| Cats is currently available for Scala 2.10 (up to 1.2.x), 2.11, 2.12, 2.13.0, and [Scala.js](http://www.scala-js.org/). | |||
|
|
|||
| Cats relies on improved type inference via the fix for [SI-2712](https://github.com/scala/bug/issues/2712), which is not enabled by default. For **Scala 2.11.9 or later** you should add the following to your `build.sbt`: | |||
| Cats relies on improved type inference via the fix for [SI-2712](https://github.com/scala/bug/issues/2712), which is not enabled by default. For **Scala 2.11.9 to 2.12.8** you should add the following to your `build.sbt`: | |||
There was a problem hiding this comment.
Scala 2.12 might release another minor version. I'd say For Scala 2.11.9+ or Scala 2.12
kailuowang
reviewed
Jul 18, 2019
README.md
Outdated
|
|
||
| ```scala | ||
| scalacOptions += "-Ypartial-unification" | ||
| ``` | ||
|
|
||
| (From Scala 2.13.0, it became partial unification on by default. The compiler no longer accepts `-Ypartial-unification`) |
There was a problem hiding this comment.
How about
Partial unification is on by default since Scala 2.13, the compiler no longer accepts `-Ypartial-unification`.
|
Thank you for your review! |
kailuowang
approved these changes
Jul 19, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update "README.md" for Scala 2.13.0 compiler specification changing(about partial unification). #2948