Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method init and last to NonEmptyChain like NonEmptyList. #2953

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Add method init and last to NonEmptyChain like NonEmptyList. #2953

merged 1 commit into from
Jul 19, 2019

Conversation

takayahilton
Copy link
Contributor

No description provided.

@takayahilton takayahilton changed the title Add method init and last to NonEmptyChain like NonEmptyList. Add method init and last to NonEmptyChain like NonEmptyList. Jul 19, 2019
@codecov-io
Copy link

codecov-io commented Jul 19, 2019 •
edited
Loading

Codecov Report

Merging #2953 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2953      +/-   ##
==========================================
+ Coverage   94.01%   94.02%   +0.01%     
==========================================
  Files         370      370              
  Lines        7032     7049      +17     
  Branches      186      180       -6     
==========================================
+ Hits         6611     6628      +17     
  Misses        421      421
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Chain.scala 99.64% <100%> (+0.01%) ⬆️
core/src/main/scala/cats/data/NonEmptyChain.scala 97.39% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed99e17...f0e2c8d. Read the comment docs.

@LukaJCB LukaJCB self-requested a review July 19, 2019 18:26
@LukaJCB
Copy link
Member

LukaJCB commented Jul 19, 2019

This looks great, thanks a bunch!

kailuowang
kailuowang approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kailuowang kailuowang merged commit c40c0a3 into typelevel:master Jul 19, 2019
@takayahilton takayahilton deleted the add/init-and-last-nec branch July 19, 2019 19:56
@kailuowang kailuowang added this to the 2.0.0-RC1 milestone Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaJCB LukaJCB LukaJCB approved these changes

@kailuowang kailuowang kailuowang approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0.0-RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@takayahilton @codecov-io @LukaJCB @kailuowang