Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snakeyaml to 1.25 #2987

Merged
merged 2 commits into from
Aug 16, 2019

Conversation

scala-steward
Copy link
Contributor

Updates org.yaml:snakeyaml from 1.24 to 1.25.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [{ groupId = "org.yaml", artifactId = "snakeyaml" }]

LukaJCB
LukaJCB previously approved these changes Aug 14, 2019
With the new version, the build fails to load with this error:
```
[info] Compiling 2 Scala sources to /home/travis/build/typelevel/cats/project/target/scala-2.12/sbt-1.0/classes ...
[info] Done compiling.
/home/travis/build/typelevel/cats/build.sbt:43: error: value asScala is not a member of Nothing
      .collect { case map: java.util.Map[_, _] => map.asScala.toList }
                                                      ^
[error] Type error in expression
```

I've no idea why this happens, but this change fixes it. I've verified
that `crossScalaVersions` still contains the versions from `.travis.yml`:

```
sbt:cats> coreJVM/crossScalaVersions
[info] * 2.11.12
[info] * 2.12.9
[info] * 2.13.0
```
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fthomas for fixing the breaking change.

@kailuowang kailuowang merged commit 01b7cbd into typelevel:master Aug 16, 2019
@travisbrown travisbrown added this to the 2.0-RC2 milestone Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants