Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cats.kernel.instances.finiteDuration package #3037

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

travisbrown
Copy link
Contributor

@travisbrown travisbrown commented Sep 8, 2019

I know #3036 isn't a high priority but this is a trivial fix, and I'd personally like to see it in 2.0.0. The name matches cats.instances.finiteDuration.

No tests, but there are no tests for the duration version, either. I confirmed that the following works:

scala> import cats.kernel.instances.finiteDuration._
import cats.kernel.instances.finiteDuration._

scala> import scala.concurrent.duration.FiniteDuration
import scala.concurrent.duration.FiniteDuration

scala> cats.kernel.LowerBounded[FiniteDuration]
res0: cats.kernel.LowerBounded[scala.concurrent.duration.FiniteDuration] = cats.kernel.instances.FiniteDurationOrder@5ac7386c

scala> cats.kernel.Hash[FiniteDuration]
res1: cats.kernel.Hash[scala.concurrent.duration.FiniteDuration] = cats.kernel.instances.FiniteDurationOrder@5ac7386c

Shouldn't break source compatibility and definitely doesn't break bincompat.

@codecov-io
Copy link

codecov-io commented Sep 8, 2019

Codecov Report

Merging #3037 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3037   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files         368      368           
  Lines        6975     6975           
  Branches      187      187           
=======================================
  Hits         6519     6519           
  Misses        456      456

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3dc2e...9cb0584. Read the comment docs.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how this breaks source compatibility, so I think this could go in whenever, no?

@travisbrown
Copy link
Contributor Author

Yeah, think so.

@LukaJCB
Copy link
Member

LukaJCB commented Sep 8, 2019

Oh okay, now that I reparse your sentence, I think you probably just had a typo 👍

@travisbrown
Copy link
Contributor Author

@LukaJCB Yeah, sorry, corrected.

@travisbrown travisbrown merged commit 9dce008 into typelevel:master Sep 9, 2019
@travisbrown travisbrown deleted the fix/3036 branch September 9, 2019 05:55
@kailuowang kailuowang added this to the 2.0.0 milestone Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants