-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to sbt 1.3.x, uses coursier by default #3079
Conversation
I am on my phone. I wonder what happened to those methods. Will take a look them Monday |
Okay, these are indeed BC breakages that were missed by previous Mima versions. Looks like we need to remove the package private on these methods. Shall we do them in this PR? Then we probably want to cherry pick to 2.0.x branch and release a patch. |
Are those supposed to be deprecated? I can do that in this PR. |
Yes. Those methods were moved to somewhere else. They are kept at the original place deprecated to maintain BC. Making them package private was an extra measure (now proven invalid) for the deprecation. |
If the build is green, I'll rebase & reorder for easier cherry-picking. |
Codecov Report
@@ Coverage Diff @@
## master #3079 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 368 368
Lines 6979 6979
Branches 184 184
=======================================
Hits 6523 6523
Misses 456 456
Continue to review full report at Codecov.
|
Ready for review. |
Could you also bump the sbt version in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much @larsrh for taking this on.
Includes & supersedes #2954, #3075, #3077.
Open problems: