Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Order constraint from Hash instance for Map #3126

Merged
merged 4 commits into from
Nov 6, 2019

Conversation

travisbrown
Copy link
Contributor

@travisbrown travisbrown commented Nov 5, 2019

This PR includes the commits by @vasiliybondarenko and @larsrh from #3060 but cleans up some of the deprecation messages, and also uses an override instead of a new name with a 1 suffix. I've also added a few lines of documentation explaining why the horrible override stuff in cats.instances.sortedSet is necessary.

@travisbrown travisbrown added this to the 2.1.0-RC1 milestone Nov 5, 2019
@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #3126 into master will decrease coverage by 0.02%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3126      +/-   ##
==========================================
- Coverage   93.22%   93.19%   -0.03%     
==========================================
  Files         375      375              
  Lines        7291     7294       +3     
  Branches      196      192       -4     
==========================================
+ Hits         6797     6798       +1     
- Misses        494      496       +2
Flag Coverage Δ
#scala_version_212 93.53% <28.57%> (ø) ⬆️
#scala_version_213 90.85% <28.57%> (-0.03%) ⬇️
Impacted Files Coverage Δ
core/src/main/scala/cats/instances/sortedSet.scala 85.71% <25%> (-2.53%) ⬇️
...ala/cats/kernel/instances/SortedSetInstances.scala 91.66% <33.33%> (-8.34%) ⬇️
core/src/main/scala/cats/data/NonEmptyList.scala 99.35% <0%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f89e3...c1b48bb. Read the comment docs.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@kailuowang kailuowang merged commit 96b5e97 into typelevel:master Nov 6, 2019
@travisbrown travisbrown changed the title Fix #3039 Remove Order constraint from Hash instance for Map Nov 14, 2019
gagandeepkalra added a commit to gagandeepkalra/cats that referenced this pull request Mar 1, 2020
travisbrown pushed a commit that referenced this pull request Mar 10, 2020
…tedSet (#3339)

* backported #3126 removed `Order` constraint from `Hash` instance for `SortedSet`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants