Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backporting ifF for scala 2.11 #3131

Closed
wants to merge 6 commits into from

Conversation

sdrafahl
Copy link

@sdrafahl sdrafahl commented Nov 7, 2019

Backporting ifF for scala 2.11.

@travisbrown
Copy link
Contributor

This unfortunately can't be added directly to the Functor trait on 2.11 because it breaks binary compatibility. You can add it to functor syntax via the BinCompat approach, and if you really wanted you could add it to Functor via an enrichment method.

@sdrafahl
Copy link
Author

sdrafahl commented Nov 7, 2019

@travisbrown Could you show me an example of the BinCompat approach? I have an idea of how to do the implicit class approach but would like to consider both?

@travisbrown
Copy link
Contributor

@sdrafahl This PR is a good example of what's necessary (it's quite painful, unfortunately, which is why we've dropped 2.11 on master 😄).

@codecov-io
Copy link

codecov-io commented Nov 29, 2019

Codecov Report

Merging #3131 into scala_2.11 will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           scala_2.11    #3131      +/-   ##
==============================================
+ Coverage        93.4%   93.49%   +0.09%     
==============================================
  Files             382      382              
  Lines            7155     7148       -7     
  Branches          195      190       -5     
==============================================
  Hits             6683     6683              
+ Misses            472      465       -7
Impacted Files Coverage Δ
core/src/main/scala/cats/Functor.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/data/NonEmptyList.scala 98.66% <0%> (-0.67%) ⬇️
core/src/main/scala/cats/data/NonEmptyVector.scala 99.13% <0%> (ø) ⬆️
core/src/main/scala/cats/instances/option.scala 100% <0%> (ø) ⬆️
.../src/main/scala/cats/laws/discipline/MiniInt.scala 97.29% <0%> (ø) ⬆️
core/src/main/scala/cats/instances/parallel.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdc7789...a310f09. Read the comment docs.

@larsrh
Copy link
Contributor

larsrh commented Jan 30, 2021

I'm closing all 2.11-related tickets since there is not enough community interest in further releases.

@larsrh larsrh closed this Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants