Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more bincompat breakage #3203

Merged
merged 3 commits into from
Dec 11, 2019
Merged

Conversation

travisbrown
Copy link
Contributor

Fixes #3202 and all related issues I was able to turn up.

@travisbrown travisbrown added this to the 2.1.0-RC3 milestone Dec 10, 2019
@codecov-io
Copy link

codecov-io commented Dec 10, 2019

Codecov Report

Merging #3203 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3203      +/-   ##
==========================================
- Coverage   93.06%   93.05%   -0.02%     
==========================================
  Files         376      376              
  Lines        7409     7412       +3     
  Branches      198      192       -6     
==========================================
+ Hits         6895     6897       +2     
- Misses        514      515       +1
Flag Coverage Δ
#scala_version_212 93.38% <100%> (-0.02%) ⬇️
#scala_version_213 92.82% <100%> (-0.02%) ⬇️
Impacted Files Coverage Δ
core/src/main/scala/cats/instances/sortedSet.scala 83.33% <100%> (-2.39%) ⬇️
laws/src/main/scala/cats/laws/MonadErrorLaws.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b813d...057fb8e. Read the comment docs.

LukaJCB
LukaJCB previously approved these changes Dec 10, 2019
@travisbrown
Copy link
Contributor Author

@kailuowang I added a comment about the overrides. What do you think?

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@travisbrown travisbrown merged commit e0e8f35 into typelevel:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More binary compatibility breakage
4 participants